Skip to content

Conversation

@chayim
Copy link
Contributor

@chayim chayim commented Nov 14, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #1708 (28b10ff) into master (3838493) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1708   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          53       53           
  Lines       11078    11078           
=======================================
  Hits         9865     9865           
  Misses       1213     1213           
Impacted Files Coverage Δ
redis/__init__.py 84.61% <100.00%> (-15.39%) ⬇️
tests/test_search.py 98.85% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3838493...28b10ff. Read the comment docs.

@chayim chayim merged commit c02d720 into master Nov 15, 2021
@chayim chayim deleted the ck-4.0.0 branch November 15, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants