SentinelManagedConnection searches for new master upon connection failure (#3560)#3601
Merged
petyaslavova merged 3 commits intoredis:masterfrom Jul 23, 2025
Merged
Conversation
Collaborator
|
Hi @ManelCoutinhoSensei, thank you for your contribution! We’ll review your change soon(after PR #3596 :) ). |
Contributor
Author
|
It's been 2 months... do you have any updates @petyaslavova ? |
petyaslavova
requested changes
Jun 26, 2025
Collaborator
petyaslavova
left a comment
There was a problem hiding this comment.
Hi @ManelCoutinhoSensei,
Apologies for the late response. I’ve reviewed the code and added a few comments.
dc0556b to
7e84758
Compare
Collaborator
|
@ManelCoutinhoSensei, please check why tests are failing. |
ed67cd1 to
1492c3a
Compare
Contributor
Author
|
Hi @petyaslavova , besides the one workflow that fails due to having the same name as another, all tests seem to pass here |
1492c3a to
7af0b7f
Compare
petyaslavova
approved these changes
Jul 23, 2025
Contributor
Author
|
Thank you so much, @petyaslavova. Once this is closed, I'll update the other PR accordingly |
petyaslavova
pushed a commit
that referenced
this pull request
Jul 25, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #3560. It should be reviewed after merging #3596