Skip to content

New abstract method added to ConnectionInterface. Adding more debug logs when processing maint notifications. Filtering some e2e tests for notifications on new connections.#3988

Merged
petyaslavova merged 8 commits intomasterfrom
ps_add_debug_logs_for_standalone_client_during_maint
Mar 9, 2026

Conversation

@petyaslavova
Copy link
Collaborator

@petyaslavova petyaslavova commented Mar 4, 2026

Adding more debug logs when processing maint notifications - helpful when troubleshooting tests.
Filtering some e2e tests for notifications on new connections - maintenance in some specific cases ends too fast, and when new connections start to wait for notification, the maintenance has already ended.


Note

Medium Risk
Adds a new abstract extract_connection_details() method to the connection interface and uses it in several failure paths, which could impact any custom connection implementations. Runtime behavior changes are otherwise limited to extra debug logging and test configuration tweaks.

Overview
Improves troubleshooting for maintenance notifications and retry/disconnect flows by adding debug-only logs that include per-connection details (via a new AbstractConnection.extract_connection_details() API) when operations fail or cluster transactions are torn down.

Enhances scenario tests by supporting optional mTLS client certs for RedisCluster setup and by filtering out an unreliable effect/trigger combination in the “new connections receive last notification” parametrized test.

Written by Cursor Bugbot for commit a642347. This will update automatically on new commits. Configure here.

@jit-ci
Copy link

jit-ci bot commented Mar 4, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@petyaslavova petyaslavova force-pushed the ps_add_debug_logs_for_standalone_client_during_maint branch from d861fe7 to 1ebca21 Compare March 5, 2026 12:29
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@petyaslavova petyaslavova added the breakingchange API or Breaking Change label Mar 9, 2026
@petyaslavova petyaslavova changed the title Adding more debug logs when processing maint notifications. Filtering some e2e tests for notifications on new connections. New abstract method added to ConnectionInterface. Adding more debug logs when processing maint notifications. Filtering some e2e tests for notifications on new connections. Mar 9, 2026
@petyaslavova petyaslavova merged commit e045654 into master Mar 9, 2026
64 checks passed
@petyaslavova petyaslavova deleted the ps_add_debug_logs_for_standalone_client_during_maint branch March 9, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange API or Breaking Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants