New abstract method added to ConnectionInterface. Adding more debug logs when processing maint notifications. Filtering some e2e tests for notifications on new connections.#3988
Merged
petyaslavova merged 8 commits intomasterfrom Mar 9, 2026
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
d861fe7 to
1ebca21
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
vladvildanov
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more debug logs when processing maint notifications - helpful when troubleshooting tests.
Filtering some e2e tests for notifications on new connections - maintenance in some specific cases ends too fast, and when new connections start to wait for notification, the maintenance has already ended.
Note
Medium Risk
Adds a new abstract
extract_connection_details()method to the connection interface and uses it in several failure paths, which could impact any custom connection implementations. Runtime behavior changes are otherwise limited to extra debug logging and test configuration tweaks.Overview
Improves troubleshooting for maintenance notifications and retry/disconnect flows by adding debug-only logs that include per-connection details (via a new
AbstractConnection.extract_connection_details()API) when operations fail or cluster transactions are torn down.Enhances scenario tests by supporting optional mTLS client certs for
RedisClustersetup and by filtering out an unreliable effect/trigger combination in the “new connections receive last notification” parametrized test.Written by Cursor Bugbot for commit a642347. This will update automatically on new commits. Configure here.