-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix races in publish_subscribe_test.rb and update truffleruby #1239
Conversation
eregon
commented
Nov 17, 2023
- See Crash in redis-client CI: truffleruby: Unexpected internal exception in at_exit oracle/truffleruby#3321
* Older versions are not supported.
You angered rubocop, but otherwise LGTM. |
7d15cb5
to
2a65de5
Compare
Fixed, and the CI passed except for that rubocop complaint: https://github.com/redis/redis-rb/actions/runs/6904372003/job/18784907013?pr=1239 |
https://github.com/redis/redis-rb/actions/runs/6904417499/job/18785060895?pr=1239
This is unrelated to this PR, it's doing Thread#join with a duration is basically an anti-pattern, even more so in tests. |
The reason is to avoid locking forever, if the thread is stuck trying to read on a socket or some other blocking operation, your CI runner hang for long enough that it's just killed and you have 0 debug information. I'm not against bumping it, but I wouldn't remove it. |
If running locally, one would Ctrl+C and then get a stacktrace, so there better without a duration as well. Yeah, GitHub Actions doesn't send SIGINT on timeout I guess, unfortunate. |
Sure, but in the meantime minitest doesn't offer that, so until it does, a generous
They at least give you which test failed, which is a decent start. |
BTW there are many other cases of |
As you wish, should I remove the last commit from this PR or keep it? |
Please remove it yes. |
OK.
That's also shown if the test hangs, because the test name is printed before it starts running. |
dbcf6f3
to
2a65de5
Compare
Removed, and ready to merge. |