Skip to content

Fix several test cases for the stuck in TruffleRuby #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
byroot merged 1 commit into from
Sep 9, 2024
Merged

Fix several test cases for the stuck in TruffleRuby #1293

byroot merged 1 commit into from
Sep 9, 2024

Conversation

@supercaracal
Copy link
Contributor

@supercaracal supercaracal commented Sep 9, 2024 •
edited
Loading

This pull request is a continuation from the above.

  • Add a timeout setting to a step in the workflow. JRuby environment may also exceed the timeout of the whole job.
  • Add a closing step to several blocks for RedisMock. They are the root cause of the weird behavior in TruffleRuby. Although I'm not still understanding the internal mechanism.

@supercaracal supercaracal marked this pull request as ready for review September 9, 2024 03:51
@byroot byroot merged commit 9938411 into redis:master Sep 9, 2024
@supercaracal supercaracal deleted the fix-a-test branch September 9, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@supercaracal @byroot