Skip to content

Perform a lazy import of optional dep nltk #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

Perform a lazy import of optional dep nltk #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245df2f
Perform a lazy import of optional dep nltk
abrookins Apr 4, 2025
a153cb6
Add a more helpful error if nltk is not installed
abrookins Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions redisvl/query/aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from typing import Any, Dict, List, Optional, Set, Tuple, Union

import nltk
from nltk.corpus import stopwords as nltk_stopwords
from redis.commands.search.aggregation import AggregateRequest, Desc

from redisvl.query.filter import FilterExpression
Expand Down Expand Up @@ -164,6 +162,14 @@ def _set_stopwords(self, stopwords: Optional[Union[str, Set[str]]] = "english"):
if not stopwords:
self._stopwords = set()
elif isinstance(stopwords, str):
# Lazy import because nltk is an optional dependency
try:
import nltk
from nltk.corpus import stopwords as nltk_stopwords
except ImportError:
raise ValueError(
f"Loading stopwords for {stopwords} failed: nltk is not installed."
)
try:
nltk.download("stopwords", quiet=True)
self._stopwords = set(nltk_stopwords.words(stopwords))
Expand Down
10 changes: 8 additions & 2 deletions redisvl/query/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from enum import Enum
from typing import Any, Dict, List, Optional, Set, Tuple, Union

import nltk
from nltk.corpus import stopwords as nltk_stopwords
from redis.commands.search.query import Query as RedisQuery

from redisvl.query.filter import FilterExpression
Expand Down Expand Up @@ -812,6 +810,14 @@ def _set_stopwords(self, stopwords: Optional[Union[str, Set[str]]] = "english"):
if not stopwords:
self._stopwords = set()
elif isinstance(stopwords, str):
# Lazy import because nltk is an optional dependency
try:
import nltk
from nltk.corpus import stopwords as nltk_stopwords
except ImportError:
raise ValueError(
f"Loading stopwords for {stopwords} failed: nltk is not installed."
)
try:
nltk.download("stopwords", quiet=True)
self._stopwords = set(nltk_stopwords.words(stopwords))
Expand Down