Update CI to use gotestfmt for clearer test output#3827
Closed
josephwoodward wants to merge 3 commits intomainfrom
Closed
Update CI to use gotestfmt for clearer test output#3827josephwoodward wants to merge 3 commits intomainfrom
gotestfmt for clearer test output#3827josephwoodward wants to merge 3 commits intomainfrom
Conversation
josephwoodward
changed the title
josephwoodward
changed the title
josephwoodward
force-pushed
the
jw/improvetestoutput
branch
3 times, most recently
from
57f872e to
32387e8
Compare
josephwoodward
force-pushed
the
jw/improvetestoutput
branch
from
4501a1a to
5ddbb37
Compare
josephwoodward
changed the title
gotestfmt for clearer test output
mmatczuk
reviewed
Dec 8, 2025
.github/workflows/test.yml
Outdated
| - name: Docs | ||
| run: CGO_ENABLED=1 TAGS=x_benthos_extra task docs && test -z "$(git ls-files --others --modified --exclude-standard)" || { >&2 echo "Stale docs detected. This can be fixed with 'task docs'."; exit 1; } | ||
|
|
||
| - name: Install gotestfmt |
Collaborator
There was a problem hiding this comment.
Since this needs to be built I wonder could we cache it?
mmatczuk
reviewed
Dec 8, 2025
josephwoodward
force-pushed
the
jw/improvetestoutput
branch
2 times, most recently
from
8659448 to
8a08b66
Compare
josephwoodward
force-pushed
the
jw/improvetestoutput
branch
from
8a08b66 to
c75c666
Compare
mmatczuk
reviewed
Dec 9, 2025
taskfiles/test.yml
Outdated
Comment on lines
28
to
29
| deps: | ||
| - :tools:install-gotestfmt |
Collaborator
There was a problem hiding this comment.
This would cause compilation on every test run. Overall it feels like the tools file needs a refactor from install-X to just X with caching. Alternatively, for simplicity, we could drop the deps.
Contributor
Author
There was a problem hiding this comment.
Yes it would. Alternatively we could check to see if the binary exists and if not return a message informing the user to install dependencies.
Contributor
Author
There was a problem hiding this comment.
Looking into this further, I've added a precondition step that will verify if gotestfmt binary is available in the bin directory, otherwise it'll return a notice informing the user to install it first.
mmatczuk
reviewed
Dec 15, 2025
| - ut | ||
| vars: | ||
| TIMEOUT: '{{if .CI}}5m{{else}}1m{{end}}' | ||
| preconditions: |
Collaborator
|
Close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds gotestfmt to the test output for local and CI test context and providers clearer test output, making it easier to navigate failed tests.
You can check the output out here under
Test:https://github.com/redpanda-data/connect/actions/runs/20029086927/job/57433439325?pr=3827