Skip to content

pbgen: support field mask protos #27058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

pbgen: support field mask protos #27058

merged 2 commits into from
Jul 30, 2025

Conversation

rockwotj
Copy link
Contributor

  • pbgen: support field mask well known type
  • protobuf: fix json encoding for duration

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.2.x
  • v25.1.x
  • v24.3.x
  • v24.2.x

Release Notes

  • none

rockwotj added 2 commits July 30, 2025 05:02
@rockwotj
pbgen: support field mask well known type
472c230
@rockwotj
protobuf: fix json encoding for duration
9f1fc70 
Well known protos have special JSON encodings. Use this encoding based
on the reference implementation.
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#69918
test_class test_method test_arguments test_kind job_url test_status passed reason
RandomNodeOperationsTest test_node_operations {"cloud_storage_type": 2, "compaction_mode": "adjacent_merge", "enable_failures": false, "mixed_versions": true, "with_iceberg": false} integration https://buildkite.com/redpanda/redpanda/builds/69918#019859f3-983b-470b-be9b-0ac217214bfe FLAKY 19/21 upstream reliability is '99.58677685950413'. current run reliability is '90.47619047619048'. drift is 9.11059 and the allowed drift is set to 50. The test should PASS

@michael-redpanda michael-redpanda merged commit 0c30019 into redpanda-data:dev Jul 30, 2025
18 checks passed
@rockwotj rockwotj deleted the field-mask branch July 30, 2025 12:03
@rockwotj
Copy link
Contributor Author

oops there is going to be a merge race

@rockwotj
Copy link
Contributor Author

#27063 to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-redpanda michael-redpanda michael-redpanda approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockwotj @vbotbuildovich @michael-redpanda