rptest: better error propagation from rp_storage_tool #27071
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
force-pushed
the
nv/rptest-rp-storage-tool-raise
branch
from
12e3658 to
6ce49d3
Compare
Less abstract failure messages.
Currently we get something like
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Logs contain stdout/stderr but it is better to surface the error to the
user. Raise an exception with stderr message.
The service name is meaningless and we can infer it from stacktrace even if it needed. The node on which the command failed is much more relevant. It can also contain (temporary) files relevant for debugging failures.
nvartolomei
force-pushed
the
nv/rptest-rp-storage-tool-raise
branch
from
6ce49d3 to
a0bfb23
Compare
|
Looks like i was wrong on the first try. rp_storage_tool actually exits with non-zero and json to stdout which should be parsed. Reverted allow_fail change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes