Fix issue with combineReducer returning incorrect type when given a custom action
#4765
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -20,6 +20,7 @@ | |||
| "resolveJsonModule": true, | |||
| "skipLibCheck": true, | |||
| "strict": true, | |||
| "exactOptionalPropertyTypes": true, | |||
There was a problem hiding this comment.
I don't have a strong opinion, but would it make sense to move this into tsconfig.test.json instead?
There was a problem hiding this comment.
I considered that but then I couldn't think of a reason for it not to live here. It's probably better here because it increases strictness for the whole repo.
There was a problem hiding this comment.
This might cause issues with the type tests at some point.
There was a problem hiding this comment.
Yeah it's probably okay for now but it might cause a hiccup or 2 at some point.
|
Thanks @timdorr. I don't think I can merge this. Can you? |
|
Welp, no one else has yelled at me, so I'll merge it in then. Thanks! |
Fixes #4764. See issue for details.
Note I had to enable
exactOptionalPropertyTypesto reproduce the bug in the test.