Add Code Review document #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawomir-gorawski-reef
force-pushed
the
code-review
branch
from
a2d8d0f to
7eac4c0
Compare
ppolewicz
reviewed
Apr 5, 2025
docs/Code_Review.md
Outdated
| pull request to the message. | ||
| 3. Sometimes it doesn’t make sense to request reviews for trivial changes – if you think no one would have anything | ||
| useful to comment on, just merge it. | ||
| 4. If no one has started reviewing your code before the daily standup, you must ask for a reviewer during the daily. |
There was a problem hiding this comment.
Suggested change
| 4. If no one has started reviewing your code before the daily standup, you must ask for a reviewer during the daily. | |
| 4. If no one has started reviewing your code before the daily standup, you [SHOULD](https://datatracker.ietf.org/doc/html/rfc2119) ask for a reviewer during the daily. |
There was a problem hiding this comment.
I'd just change "must" to "should" without the RFC link
Co-authored-by: Paweł Polewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.