Draft
Conversation
Add two planning documents for the goals feature implementation: - goals-feature-master-plan.md: framing doc with PR dependency graph, API gap analysis, and layer-by-layer implementation plan - goals-backend-questions.md: four architectural questions (goal scoping, action-goal FK, SSE events, annotation persistence) to resolve with the backend team before frontend work begins
jhodapp
added
documentation
jhodapp
changed the title
All four backend questions (Q1–Q4) are now resolved: - Q1: Join table (coaching_sessions_goals) confirmed - Q2: Direct goal_id FK on actions confirmed - Q3: Renamed SSE events + two new join table events - Q4: Both SSE + load-time validation with per-entity-type endpoints Also incorporates rename decisions: overarching_goals → goals, coaching_session_id → created_in_session_id, and backend 5-PR plan.
- Rename GET /goals/{id}/health_metrics → GET /goals/{id}/health
to match backend's GoalsFeatureEndpointReference contract
- Clarify health heuristics: momentum-only when target_date is null
- Incorporate created_in_session_id nullable decision
- Incorporate target_date field decision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
These planning docs establish the roadmap for turning the goals prototypes (
src/app/prototype/) into production code across 10 PRs organized in 5 layers. No code changes — documentation only.