Closed
Conversation
Complements backend PR #234 which renames the overarching_goals DB table, API endpoints, and SSE events. This PR updates all frontend references to match: types, API client, SSE cache invalidation, components, consumers, and 14 test files (~90 references across 30 files). Must deploy simultaneously with backend PR #234.
1 task
Member
Author
|
Closing to re-open as a fresh PR to trigger a clean CI run for the PR Preview pipeline fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames all
overarching_goalreferences togoalacross the entire frontend codebase — types, API client, SSE event handlers, components, and tests.This is the first step in a wider refactor and enhancement of goals throughout the platform.
GitHub Issue: Complements backend refactor-platform-rs PR #234
Changes
git mv(overarching-goal.ts→goal.ts,overarching-goals.ts→goals.ts,overarching-goal.tsx→goal.tsx,overarching-goal-container.tsx→goal-container.tsx)OverarchingGoal→Goal,OverarchingGoalSortField→GoalSortField, SSE event types,EnrichedCoachingSession.overarching_goal→.goal,GoalContext.overarchingGoalId→.goalId/overarching_goals→/goals,OverarchingGoalApi→GoalApi, all SWR hooks renamedoverarching_goal_*→goal_*, endpoint path/overarching_goals→/goalsbuildGoalContext()andgroupActionsByGoal()in assigned-actions utilsTesting Strategy
npx tsc --noEmit— 0 new errors (1 pre-existing in unrelated prototype file)npm run lint— 0 errorsnpm test— 58 test files, 596 tests all passinggrep -ri "overarching" src/ __tests__/— 0 matchesConcerns
/overarching_goalsAPI calls and miss renamed SSE events.