-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mantine 7 support #5340
Mantine 7 support #5340
Conversation
🦋 Changeset detectedLatest commit: 515dc57 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @glebtv, thank you for the PR! Great work! I'll request reviews from the core members and let's see what we can work on here. I had a quick look and it looks good actually and I think we can provide couple of solutions for the CSS and then we can just update the mantine examples and ship it 🚢 About the styling issues, I think there are couple of solutions that we can try;
Thanks again for the PR, we'll keep you updated as soon as possible when we have the chance for a detailed review. 🚀 |
any update on this? :) thanks for your pr! |
Hello @piccinnigius, we are waiting for @glebtv to make the requested changes. if @glebtv is not available and you would like to continue this development, we would appreciate it 🙌 |
Hey @glebtv , any update on this? :) highly appreciated! |
Hey @amirmamaghani we are open to contributions from the community, as the original owner of the PR seeems to be unresponsive. |
Hey @BatuhanW , is there any how to guide how to work on these subpackages? I quickly tried to run it but I find it difficult to dig through sourcecodes without seeing any Storybook or sth. Thanks! |
Hey @amirmamaghani you can check our contribution guide. https://refine.dev/docs/guides-concepts/contributing/ |
Hi, what exactly do you need help with this PR? Fix checks or something else? |
Sorry, I didn't have any time for this PR, but now I have rebased it to current master and am planning to fix the remaining examples soon |
I made @test at packages/ui-tests/tsup.config.ts a separate entrypoint so TestWrapper and render function could be replaced to add MantineProvider to the tests. Unfortunately this breaks tests in other packages because ui-tests start to use test helpers and TestWrapper from the package and not from ui-tests itself And TestWrapper in ui-tests uses legacy router, as most of ui-tests A better solution is welcome if anyone has any |
Can someone trigger tests and examples build please? |
Please try the builds again, all tests and examples should work now. Please note there is now This component is currently a wrapper around mantine's Selelct but can be later replaced with a custom implementation, like https://mantine.dev/combobox/?e=AsyncAutocomplete But Mantine select is overall not as good as react-select, maybe replace it with react-select? Also should I rewrite\clean up the commits or will you squash them? |
This PR will also fix MUI snapshots, currently they are broken because of random css- classes. Will update the branch to fix a conflict in snapshots |
Co-authored-by: Alican Erdurmaz <[email protected]>
Is this PR on-track to land in the April Refine release? |
Passing run #10884 ↗︎
Details:
Review all test suite changes for PR #5340 ↗︎ |
Hey @glebtv, we've merged |
Hey @glebtv sorry for the inconvenience. I've also emailed you. |
Any news about Mantine 7 support guys ? Thanks ! |
I'm sorry but currently I don't have time to continue this work, anyone is free to open a new pull using (or not using) my changes |
Hey @glebtv thanks for the contributions! You've come a long way and we appreciate it. @mkhennoussi We are open to community contributions for this one. |
closes #5178
Notable problems:
Mantine 7 uses CSS modules for styling, and @refinedev/mantine uses tsup to build, which doesn't support css modules
egoist/tsup#536
Any input or feedback welcome
Mantine migration guides:
https://v6.mantine.dev/changelog/6-0-0/
https://mantine.dev/guides/6x-to-7x/