feat(graphql): rewrite GraphQL data provider #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1fc9b01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was
linked to
issues
Sep 19, 2024
omeraplak
approved these changes
Sep 19, 2024
aliemir
requested changes
Sep 19, 2024
BatuhanW
force-pushed
the
RK-780-refine-improve-graphql-data
branch
from
b0d9a1d to
956abe0
Compare
aliemir
requested changes
Oct 7, 2024
addressed review comments removed newOptions temp file, fixed typings for options
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
RK-780-refine-improve-graphql-data
|
| Run status |
|
| Run duration | 11m 24s |
| Commit |
|
| Committer | Batuhan Wilhelm |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
13
|
| View all changes introduced in this branch ↗︎ | |
…file and some cleanups
aliemir
reviewed
Oct 10, 2024
rename "countMapper" to "getTotalCount" for clarity get rid of separate buildPagination, buildSorters, buildFilters in getList options and use single buildVariables remove wrapping response with array in data provider updateMany and deleteMany methods and move to respective options config deep merge user provided options with base options add options typescript type
…{Paging,Filter,Sorting} methods since they are under buildVariables now
aliemir
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes #5942 #5943
Notes for reviewers