fix(core): reset table filters and sorters on current page re-navigate via side-nav

[arndom]

• Update useTable hook to handle case where a user navigates to current page by clicking side-nav link intending to reset the filters and sorters.

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

• Related issue(s) linked
• Tests for the changes have been added
• Docs have been added / updated
• Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

In a table, apply some filters/sorters then click the menu item in the sidebar, the URL should reset filters and sorters to the default but it doesn't.

This can be previewed at https://example.admin.refine.dev/orders

What is the new behavior?

The above has been resolved. It resets the query params for filters and sorters back to their defaults.

fixes #6300

Notes for reviewers

[changeset-bot]

🦋 Changeset detected

Latest commit: 089edd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@refinedev/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[BatuhanW]

Hey @arndom thanks for the PR, please make sure to add tests for the behavior.

[aliemir]

Hey @arndom thank you for your effort! 🙏 I've left a comment in the issue (#6300 (comment)) about the implementation we're looking for.

While your changes will work for the reported case, it won't cover other cases such as changing the query params without using the useTable hook.

Let us know if you can work on the changes described in the comment 🙏

[arndom]

@aliemir Sure, it's best to finish what I started properly...though I may need some guidance as I'm still fresh on the codebase

[BatuhanW]

Hey @arndom are you gonna be able to continue on this PR? Please let us know if you need help with a specific issue. We'd be happy to guide you through.

[arndom]

@BatuhanW I still plan to, I just haven't had the time recently due to my work schedule. Some help on the approach to solving this would be great.

My current thought process: Since syncWithLocation defined in refine context is used by multiple implementations for params syncing, a change in all those may provide a fix (possibly a shared function). I am unsure about its efficiency or if there are better solutions as I haven't spent that much time in the repo.

[arndom]

@aliemir I believe the recent commits take into consideration the updating of filters and sorters; URL state -> internal state and vice versa.

[aliemir]

Hey @arndom, I've tried on my local but looks like the effect is exceeding the max depth and even if I ignore it, it starts looping when I have a change in filters 🤔 I'll try to look again to see what went wrong and at least provide tips to get it back on track 🙏

[arndom]

Sorry about that, seems I did not test properly, I'll go through it again and resolve the issues

[BatuhanW]

Hey @arndom feel free to re-open it when your changes are complete.