Entry points bumps plugins #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmaranville
requested review from
glass-ships,
pkienzle and
Copilot
and removed request for
glass-ships and
pkienzle
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new bumps scheme for defining plugin behavior via entry points and sets the active plugin as "refl1d" for both CLI and GUI modes. Key changes include:
- Removal of deprecated plugin registration code in cli.py and main.py.
- Introduction of a new error plotting function (errplot) in fitplugin.py.
- Updates to pyproject.toml with new entry point definitions for plugin interfaces.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| refl1d/webview/server/cli.py | Removed deprecated commented code; streamlined CLI setup. |
| refl1d/main.py | Removed setup_bumps, set ACTIVE_PLUGIN_NAME directly in CLI/GUI. |
| refl1d/bumps_interface/migrations.py | Added full_migration function with strict schema version check. |
| refl1d/bumps_interface/fitplugin.py | Removed unused functions and added the errplot function. |
| pyproject.toml | Added and updated entry point definitions for new bumps scheme. |
| doc/conf.py | Removed manual plugin registration. |
Comments suppressed due to low confidence (1)
pyproject.toml:64
- There is an entry point defined for 'save_json' targeting refl1d.bumps_interface.fitplugin:save_json, but this function is not defined in the provided diff. Please ensure that a proper implementation is added.
[project.entry-points."bumps.serialize.save_json"]
pyproject.toml
Outdated
| [project.entry-points."bumps.calc_errors"] | ||
| refl1d = "refl1d.uncertainty:calc_errors" | ||
|
|
||
| [project.entry-points."bumps.show_errors.maptlotlib"] |
There was a problem hiding this comment.
The entry point name 'bumps.show_errors.maptlotlib' appears to have a typo. It is likely intended to be 'bumps.show_errors.matplotlib'.
Suggested change
| [project.entry-points."bumps.show_errors.maptlotlib"] | |
| [project.entry-points."bumps.show_errors.matplotlib"] |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new bumps scheme for defining plugin behavior with entry points. (depends on bumps/bumps#284)
Sets the active plugin as "refl1d" before starting the wx GUI.