-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for rofication-replacement #63
Update docs for rofication-replacement #63
Conversation
Thank you @kronn, this looks good to me, but I'm gonna let @kgilmer take a closer look. But there are two points I want to mention now:
|
Oh sure. No pressure from my side. |
It's ok to rebase! |
4fd69d2
to
e22b66e
Compare
✅ Deploy Preview for regolith-desktop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
You really changed everything, while keeping everything. Looks good. I made the rebase. After that is merged, I will kill my fork and fork new, this seems easier than trying to update things. And yes, I realize that this is both equivalent to "turning it off and on again" and "giving up on proper housekeeping". Anyway, I rebased, you can look for typos in my changes again :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry took me a long time to get around to this. There are a few cosmetics comments below. Otherwise content wise lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more.
I am kinda sad that I missed the indentation. Now it's there and it looks better, suddenly the numbers make sense 😁 Also: which linter do you use? I want to update my setup to cover these easily fixable problems. |
I'm using markdownlint in VSCode. |
At first I was happy about the calm and quite that Rofication brings. Then I missed several notifications while being focussed.
A few simple apt-commands later I noticed that the docs for this are 95% up-to-date. The remaining 5 % (in my perception at least) are in this PR.