Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for rofication-replacement #63

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

kronn
Copy link
Contributor

@kronn kronn commented Jan 29, 2025

At first I was happy about the calm and quite that Rofication brings. Then I missed several notifications while being focussed.

A few simple apt-commands later I noticed that the docs for this are 95% up-to-date. The remaining 5 % (in my perception at least) are in this PR.

@khos2ow
Copy link
Member

khos2ow commented Jan 31, 2025

Thank you @kronn, this looks good to me, but I'm gonna let @kgilmer take a closer look. But there are two points I want to mention now:

  • we've renamed the repository to regolith-linux/regolith-desktop.com. So you might need to adjust your cloned url accordingly
  • we are in the process of redesigning the website (feat: redesign the whole website with Hextra theme #65), maybe we can hold off of this PR until we merge that and you can rebase here

@kronn
Copy link
Contributor Author

kronn commented Jan 31, 2025

Oh sure. No pressure from my side.

@khos2ow
Copy link
Member

khos2ow commented Feb 7, 2025

It's ok to rebase!

@kronn kronn force-pushed the notification-daemon-replacement branch from 4fd69d2 to e22b66e Compare March 7, 2025 07:43
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for regolith-desktop ready!

Name Link
🔨 Latest commit 588ed4d
🔍 Latest deploy log https://app.netlify.com/sites/regolith-desktop/deploys/67dad26a6993d10008ddb589
😎 Deploy Preview https://deploy-preview-63--regolith-desktop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kronn
Copy link
Contributor Author

kronn commented Mar 7, 2025

You really changed everything, while keeping everything. Looks good. I made the rebase. After that is merged, I will kill my fork and fork new, this seems easier than trying to update things. And yes, I realize that this is both equivalent to "turning it off and on again" and "giving up on proper housekeeping".

Anyway, I rebased, you can look for typos in my changes again :-)

@kronn
Copy link
Contributor Author

kronn commented Mar 11, 2025

Copy link
Member

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry took me a long time to get around to this. There are a few cosmetics comments below. Otherwise content wise lgtm!

Copy link
Member

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more.

@kronn
Copy link
Contributor Author

kronn commented Mar 19, 2025

I am kinda sad that I missed the indentation. Now it's there and it looks better, suddenly the numbers make sense 😁

Also: which linter do you use? I want to update my setup to cover these easily fixable problems.

@khos2ow
Copy link
Member

khos2ow commented Mar 19, 2025

I'm using markdownlint in VSCode.

@khos2ow khos2ow merged commit 20153bc into regolith-linux:main Mar 19, 2025
4 checks passed
@kronn kronn deleted the notification-daemon-replacement branch March 19, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants