Conversation
|
Maybe backout the lockfile changes and try to relock here? |
|
/relock-conda |
It was just outdated, I can very easily now relock locally as well :D |
beckermr
left a comment
There was a problem hiding this comment.
I have lots of questions on this one. In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.
I cannot fix typing issues without removing wrongly typed dead code. I also need to change variable assignments minimally if the code is trying to change the type of a variable dynamically. If principles of inheritance are violated, adjustments need to be made to fix them. There are no "unassociated changes" in this PR. |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (75.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 80.80% 80.84% +0.03%
==========================================
Files 143 143
Lines 16333 16326 -7
==========================================
Hits 13198 13198
+ Misses 3135 3128 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix
beckermr
left a comment
There was a problem hiding this comment.
I am feeling pretty nervous about merging this PR. Is it possible to break it up into changes that only effect type declarations and into changes that change the code? Then we write some additional tests for the second set of changes, but move the typing ones ahead.
|
Next week, @pavelzw and I will make significant progress with #261. Since integration tests would build a lot more confidence in merging changes like this, it's probably worth waiting for that. I don't think splitting these changes further into "problematic" and "non-problematic" issues is worth the hassle. |
|
@beckermr Now that we have integration tests that should cover most "random" failures, I'd like to revive this series of PRs again. Could you please take a look? The functional change around |
|
/relock-conda |
|
I've relocked the dependencies with conda-lock! The following packages have been updated:
|
|
@beckermr any news here? |
|
Thanks for raising this. I think this happened somewhere in a merge conflict. All done! |
|
Let me fix the lockfile |
|
/relock-conda |
|
I've relocked the dependencies with conda-lock! The following packages have been updated:
|
Description:
This PR fixes some mypy issues. Around 180 errors are left.
Checklist:
Cross-refs, links to issues, etc: