Skip to content

fix some mypy issues#3203

Merged
ytausch merged 22 commits intoregro:mainfrom
ytausch:mypy
Sep 9, 2025
Merged

fix some mypy issues#3203
ytausch merged 22 commits intoregro:mainfrom
ytausch:mypy

Conversation

@ytausch
Copy link
Contributor

@ytausch ytausch commented Nov 25, 2024

Description:

This PR fixes some mypy issues. Around 180 errors are left.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:


@ytausch ytausch requested a review from beckermr November 25, 2024 16:44
@beckermr
Copy link
Contributor

Maybe backout the lockfile changes and try to relock here?

@beckermr
Copy link
Contributor

/relock-conda

@ytausch
Copy link
Contributor Author

ytausch commented Nov 25, 2024

Maybe backout the lockfile changes and try to relock here?

It was just outdated, I can very easily now relock locally as well :D

@ytausch ytausch marked this pull request as ready for review November 25, 2024 16:47
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have lots of questions on this one. In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.

@ytausch
Copy link
Contributor Author

ytausch commented Nov 25, 2024

In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.

I cannot fix typing issues without removing wrongly typed dead code. I also need to change variable assignments minimally if the code is trying to change the type of a variable dynamically. If principles of inheritance are violated, adjustments need to be made to fix them.

There are no "unassociated changes" in this PR.

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

❌ Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.84%. Comparing base (c43e40a) to head (236d99e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 25.00% 9 Missing ⚠️
conda_forge_tick/container_cli.py 0.00% 6 Missing ⚠️
conda_forge_tick/status_report.py 0.00% 2 Missing ⚠️
conda_forge_tick/migrators/license.py 75.00% 1 Missing ⚠️
conda_forge_tick/migrators/version.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   80.80%   80.84%   +0.03%     
==========================================
  Files         143      143              
  Lines       16333    16326       -7     
==========================================
  Hits        13198    13198              
+ Misses       3135     3128       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am feeling pretty nervous about merging this PR. Is it possible to break it up into changes that only effect type declarations and into changes that change the code? Then we write some additional tests for the second set of changes, but move the typing ones ahead.

@ytausch
Copy link
Contributor Author

ytausch commented Nov 29, 2024

Next week, @pavelzw and I will make significant progress with #261. Since integration tests would build a lot more confidence in merging changes like this, it's probably worth waiting for that.

I don't think splitting these changes further into "problematic" and "non-problematic" issues is worth the hassle.

@ytausch ytausch mentioned this pull request Feb 14, 2025
3 tasks
@ytausch ytausch requested a review from beckermr September 2, 2025 19:38
@ytausch
Copy link
Contributor Author

ytausch commented Sep 2, 2025

@beckermr Now that we have integration tests that should cover most "random" failures, I'd like to revive this series of PRs again. Could you please take a look?

The functional change around start_time is type-related and should be pretty trivial to manually verify.

@ytausch
Copy link
Contributor Author

ytausch commented Sep 2, 2025

/relock-conda

@regro-cf-autotick-bot
Copy link
Collaborator

I've relocked the dependencies with conda-lock!

The following packages have been updated:

  • platform: osx-arm64

    • mypy: None -> 1.17.1
  • platform: linux-64

    • mypy: None -> 1.17.1
  • platform: osx-64

    • mypy: None -> 1.17.1

@ytausch
Copy link
Contributor Author

ytausch commented Sep 9, 2025

@beckermr any news here?

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue.

@ytausch
Copy link
Contributor Author

ytausch commented Sep 9, 2025

Thanks for raising this. I think this happened somewhere in a merge conflict. All done!

@ytausch
Copy link
Contributor Author

ytausch commented Sep 9, 2025

Let me fix the lockfile

@ytausch
Copy link
Contributor Author

ytausch commented Sep 9, 2025

/relock-conda

@regro-cf-autotick-bot
Copy link
Collaborator

I've relocked the dependencies with conda-lock!

The following packages have been updated:

  • platform: osx-arm64

    • conda-forge-feedstock-check-solvable: 0.11.2 -> 0.11.3
    • conda-forge-pinning: 2025.09.01.21.18.50 -> 2025.09.09.13.18.56
    • pygithub: 2.8.0 -> 2.8.1
    • pytest-cov: 6.2.1 -> 6.3.0
    • rattler-build: 0.46.0 -> 0.47.0
    • rattler-build-conda-compat: 1.4.5 -> 1.4.6
  • platform: linux-64

    • conda-forge-feedstock-check-solvable: 0.11.2 -> 0.11.3
    • conda-forge-pinning: 2025.09.01.21.18.50 -> 2025.09.09.13.18.56
    • pygithub: 2.8.0 -> 2.8.1
    • pytest-cov: 6.2.1 -> 6.3.0
    • rattler-build: 0.46.0 -> 0.47.0
    • rattler-build-conda-compat: 1.4.5 -> 1.4.6
  • platform: osx-64

    • conda-forge-feedstock-check-solvable: 0.11.2 -> 0.11.3
    • conda-forge-pinning: 2025.09.01.21.18.50 -> 2025.09.09.13.18.56
    • pygithub: 2.8.0 -> 2.8.1
    • pytest-cov: 6.2.1 -> 6.3.0
    • rattler-build: 0.46.0 -> 0.47.0
    • rattler-build-conda-compat: 1.4.5 -> 1.4.6

@ytausch ytausch enabled auto-merge September 9, 2025 15:44
@ytausch ytausch added this pull request to the merge queue Sep 9, 2025
Merged via the queue into regro:main with commit 94ccd5a Sep 9, 2025
10 of 11 checks passed
@ytausch ytausch deleted the mypy branch September 9, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants