Pr/new prominence tokens #206
Conversation
Merge next to master
Release next to master
Adds new low-CLS fallback fonts introduced here: rei/rei-cedar#178
c4rlosviteri
force-pushed
the
pr/new-prominence-tokens
branch
2 times, most recently
from
38fd879 to
b04c34c
Compare
c4rlosviteri
force-pushed
the
pr/new-prominence-tokens
branch
from
b04c34c to
8953eed
Compare
dist/docsite/js/cdr-tokens.cjs
Outdated
| "CdrProminenceLiftedShadow5Blur": "36px", | ||
| "CdrProminenceLiftedShadow5Spread": "0", | ||
| "CdrProminenceFlat": [{"color":"#000000","offsetX":"0","offsetY":"0","blur":"0","spread":"0"}], | ||
| "CdrProminenceRaised": [{"color":"rgba(75, 74, 72, 0.07)","offsetX":"0","offsetY":"1px","blur":"1px","spread":"0"},{"color":"rgba(75, 74, 72, 0.02)","offsetX":"0","offsetY":"2px","blur":"1px","spread":"0"},{"color":"rgba(75, 74, 72, 0.00)","offsetX":"0","offsetY":"2px","blur":"1px","spread":"0"}], |
There was a problem hiding this comment.
I would expect this to be a single line, rather than an array—what do you folks think? These variables are definitely less used, but I was under the impression these should be a single line and could be used as-is by a consumer without needing to join an array.
There was a problem hiding this comment.
Like a CSS value?
There was a problem hiding this comment.
my understanding was that these would be used to create a prominence composite is that not the case?
| import concat from 'concat'; | ||
| import path from 'path'; | ||
| import { getDirname } from '../utils.mjs'; | ||
| import fs from 'fs-extra' |
There was a problem hiding this comment.
Was this file changed? I think the same question applies to a few of the files in this PR. I would like to get Prettier in this library, which would alleviate these types of questions, but we have not added it in yet
There was a problem hiding this comment.
I run eslint to fix those problems. But yeah, I agree. We need Prettier. Do you want me to add it in this PR too?
There was a problem hiding this comment.
Lets get it in the next one after this gets merged in, it's ok as-is
| type: 'value', | ||
| transitive: true, | ||
| filter: (token) => token.$type === 'shadow', | ||
| transform: (token) => { |
Important: PR based on the v4 update