Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all dot leading folders #128

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Ignore all dot leading folders #128

merged 2 commits into from
Dec 28, 2023

Conversation

gforcada
Copy link
Collaborator

@gforcada gforcada commented Dec 28, 2023

@reinout indeed, ignoring all dot leading folders is important!!

I forgot to do some real testing, and once I did that, after the release, the first one already showed the problem: .tox stalls the processing 😕

I refactored, a bit, the scanners to share the filtering logic on a single function 🧹

@coveralls
Copy link

coveralls commented Dec 28, 2023

Coverage Status

coverage: 99.968%. remained the same
when pulling 08b2c38 on ignore-tox
into 78e8937 on master.

@gforcada gforcada changed the title Ignore tox Ignore all dot leading folders Dec 28, 2023
@gforcada
Copy link
Collaborator Author

We might want to expand this by allowing users to specify a list of folders to be ignored, probably.

node_modules is the default folder if you have some JS code within a python distribution, but the name might as well be another...

@gforcada gforcada merged commit 6eccaed into master Dec 28, 2023
6 checks passed
@gforcada gforcada deleted the ignore-tox branch December 28, 2023 11:22
@gforcada
Copy link
Collaborator Author

I did merge and release z3c.dependencychecker==2.14.1 to fix this obvious performance regression 😓

@reinout
Copy link
Owner

reinout commented Dec 28, 2023

Common problem. .gitignore, .dockerignore... There are multiple places where I occasionally trip over to-ignore or to-include stuff. I wonder if there's some existing thing we can use? Probably we'll need a custom one.

@gforcada
Copy link
Collaborator Author

Another approach would be to use something like git ls-files and only scan those files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants