fix: add 'true' as 3rd argument of ClosureExpressionVisitor::getObjectFieldValue() #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes compatibility with Doctrine Collections 2.4 by adding the third parameter (true) to ClosureExpressionVisitor::getObjectFieldValue() method calls. This parameter controls whether the method should return null for non-existent properties instead of throwing an exception, allowing the calling code to provide more specific and helpful error messages through custom exception handling.
- Adds the nullable parameter to allow graceful handling of missing properties
- Enables better error messaging through application-specific exceptions
- Ensures compatibility with Doctrine Collections 2.4 while maintaining backward compatibility with 2.2+
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rekapager-doctrine-collections-adapter/src/Internal/SelectableKeysetItem.php | Updated getObjectFieldValue() call to allow nullable return, enabling custom NullBoundaryValueException with detailed error context |
| packages/rekapager-adapter-common/src/IndexResolver.php | Updated getObjectFieldValue() call to allow nullable return, improving error handling within the existing try-catch block |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.