Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using hosted image of a cat-dev #12

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

Mythra
Copy link
Contributor

@Mythra Mythra commented Apr 7, 2024

in the past i encoded a gigantic jpeg as Base64 just because I really wanted everyone to be able to edit the image and preview the image. unfortunately, most sites (github included) choose to not allow base64 encoded images (or maybe not as large of base64 encoded images).

this means while anyone could submit a pr for it, it just wouldn't render on most sites. making it useless. now it's uploaded to one of my loose backblaze buckets, which means not everyone can techincally own it, but folks can submit a pr, i upload the image, and then the pr works. OR we can choose a more community owned url mirror later on too. it doesn't need to be my bucket.

this will at least let the image render on pretty much every site.

in the past i encoded a gigantic jpeg as Base64 just because I really
wanted _everyone_ to be able to edit the image and preview the image.
unfortunately, most sites (github included) choose to not allow base64
encoded images (or maybe not as large of base64 encoded images).

this means while anyone could submit a pr for it, it just wouldn't
render on most sites. making it useless. now it's uploaded to one of my
loose backblaze buckets, which means not everyone can techincally own
it, but folks can submit a pr, i upload the image, and then the pr
works. OR we can choose a more community owned url mirror later on too.
it doesn't need to be my bucket.

this will at least let the image render on pretty much every site.
@Mythra Mythra merged commit 6c70213 into trunk Apr 7, 2024
15 checks passed
@Mythra Mythra deleted the dev/tired-of-assets-not-working branch April 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant