Various Updates & Fixes to bridgectl
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update our dependencies to their latest versions
- also pre-emptively bump our misc version for packaging
- don't error out when using the `--help` flag on bridgectl
- we should only error when you specify no args including no help flag
- allow configuring the parameter space port
- i see this option in `setup.cgi` of my MION, i don't know why none
of the tools techincally allow you to configure this port.
- bridgectl was not respecting `cafe`/`cafex`/`mochiato` env vars
- this wasn't necissarily a bug, but a behaviour we should support
to continue making bridgectl "just work" when you'd expect it too.
- this wasn't added in previous commits because:
- `mochiato` doesn't techincally exist yet, due to other missing
pre-requisites before it can be implemented.
- while running under `cafe`/`cafex` for Sprig is supported, it
is not something I do frequently. this was just one behavior
i had missed because i wasn't thinking about it.
- this basically just gets around needing to manually specify
`-d`/`--default` or a bridge name/ip/mac when running with the
environment variables that get set by `cafe`/`cafex`/`mochiato`
- also fixed several outputs where things like set-parameters said
it can't "get parameters", even though you're trying to... set
parameters not get them.
- fix some bad documentation links in `cat-dev`
- this was because i had changed some module paths, and variable names
- also start throwing in some WIP parts of MION FSEmul work,
specifically talking to `control.cgi` which is used to actually tell
the MION to power on, and get some information about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was originally meant to be the first commit of
FSEmulsupport (hence the branch name beingdev/fsemul). However, while working on it I noticed some very small things I want to contribute up, because FSEmul is probably going to take awhile. Some of these fixes, and things are:Update LICENSE file to the latest year (2024)
Update various dependencies to latest version.
Fix various commands in
bridgectlshowing the wrong command name/purpose when error'ingdump-params/get-params/set-paramsare pretty similar and I copied a lot, and didn't fully fix the copying. whoops, that's on me!Teach
bridgectlaboutcafe/cafex/mochiatoenvironment variables for specifying the bridge. This means in acafe/cafex/mochiatoenvironment you don't need to specify which bridge you want to use at all (not even a--default)bridgectlwhere specifying absolutely no parameters would still try to search, and potentially find a bridge. we wouldn't want this.Allow configuring the parameter space port for
get-params/set-params/dump-paramsFix
bridgectlexiting with an unsuccessful exit code, when specifying--help/-has an argument.