Greatly Rework Bridgectl for Consistency, Speed, Functionality, and More #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see by the branch name, I was once again hoping to work through PCFS, but while working on it I was having such frustrations with the current subpar architecture of
bridgectl(admittedly my own quick prototyping fault).This greatly reworks
bridgectlto have significantly more consistent behavior, flags, descriptions, and more. Specifically this moves to a concept of using static variables that are initialized, and actually sharing argument structures. This means all of the commands that need to target a specific bridge ip, or name actually have the same flags, and same lookup behavior. Rather than it being copied over all over the place, with slightly different buggy behaviors.It also actually causes significantly less lookups as we know how to use the configuration file/environment variables to help prevent lookups when possible.
Overall I tested some very common things, so this should all work. However, there may be one or two small bugs introduced as a result.