in case properties is undefined

[xiaoxinghu]

properties field in Element type is optional (according to hast definition). when they are, this will crash. Maybe should be more tolerate here?

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything or linked relevant results below
• I made sure the docs are up to date
• I included tests (or that’s not needed)

Description of changes

use optional chaining when accessing properties of Element.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e99b9d0) to head (30b8491).
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        14    -1     
  Lines         1823      1831    +8     
=========================================
+ Hits          1823      1831    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wooorm]

Hi! :)

according to hast definition

I do not think so. Where do you base this statement on?

---

Sounds like you are using/writing a plugin with a bug. Better solve it there!

[JounQin]

@wooorm It's indeed saying properties is optional at

https://github.com/syntax-tree/hast/blob/8264a4dea322ab1c95322af0a24080488b414d78/readme.md?plain=1#L171

[wooorm]

Huh! Not sure where that ? is from. It wasn’t there earlier: https://github.com/syntax-tree/hast/blob/845fa62a70597cb50b80bbe76e33067169d4fd68/readme.md#element. I don’t remember intentionally adding optionality.

[JounQin]

I don’t remember intentionally adding optionality.

😄 7 years ago.

syntax-tree/hast@3d15ab3#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15R113-R118

[xiaoxinghu]

Nice! Thanks for the clarification.