Dedupe calls to route.lazy functions
#13260
Conversation
🦋 Changeset detectedLatest commit: a69ddf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| loader: undefined, | ||
| action: undefined, | ||
| children: undefined, | ||
| id: r.id || `route-${guid++}`, | ||
| }; | ||
| if (r.lazy) { | ||
| // @ts-expect-error | ||
| enhancedRoute.lazy = (args) => { |
There was a problem hiding this comment.
I've removed the lazy route helpers since the new approach to deduping means that it's more of a top-level concern within the test, not tied to individual navigations. This simplified the tests quite a bit, and will make it easier to test other types for route.lazy in the future.
There was a problem hiding this comment.
That should be fine - the real advantage of the booleans for loader/actions is that they auto-regenerate new promises for each navigation/fetch so you can do out of order resolving and test interruption flows and such. With lazy already taking "first return wins" and now being deduped and effectively a singleton resolution that approach isn't really necessary 👍
There was a problem hiding this comment.
Sounds good. That was exactly my thinking too.
| @@ -392,7 +392,7 @@ export interface MapRoutePropertiesFunction { | |||
| * onto the route. Either they're meaningful to the router, or they'll get | |||
| * ignored. | |||
| */ | |||
| export type ImmutableRouteKey = | |||
| export type UnsupportedLazyRouteFunctionKey = | |||
There was a problem hiding this comment.
This rename is in preparation for the additional type for lazy route objects.
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
This PR is in preparation for more granular
route.lazysupport. This updates the existing logic to ensure calls toroute.lazyare deduped, which is how the more granular object-based API is intended to work. This also means that the tests are now updated to be more flexible in terms of the types forroute.lazy, rather than testing using thelazy: trueflag on theTestRouteObjecttype. This will make introducing object-basedroute.lazytests much easier.