-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty assets
object from wrangler config
#13302
base: dev
Are you sure you want to change the base?
Remove empty assets
object from wrangler config
#13302
Conversation
|
Hi @smorimoto, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
We've been using this change in production for about a week now and it works fine. |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
2913af9
to
d90743a
Compare
I bumped the packages from |
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
d90743a
to
ed38459
Compare
As of
@cloudflare/vite-plugin
v0.1.14, theassets
field in the Wrangler config is now optional. Ref: https://github.com/cloudflare/workers-sdk/blob/main/packages/vite-plugin-cloudflare/CHANGELOG.md#0114This PR removes the now redundant empty
assets
object from the configuration.Ref: cloudflare/workers-sdk#8545