Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty assets object from wrangler config #13302

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

smorimoto
Copy link

As of @cloudflare/vite-plugin v0.1.14, the assets field in the Wrangler config is now optional. Ref: https://github.com/cloudflare/workers-sdk/blob/main/packages/vite-plugin-cloudflare/CHANGELOG.md#0114

This PR removes the now redundant empty assets object from the configuration.

Ref: cloudflare/workers-sdk#8545

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: ed38459

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 25, 2025

Hi @smorimoto,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@smorimoto
Copy link
Author

We've been using this change in production for about a week now and it works fine.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 25, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@smorimoto smorimoto changed the base branch from main to dev March 25, 2025 20:13
@smorimoto smorimoto force-pushed the remove-assets-from-wrangler-conf branch 2 times, most recently from 2913af9 to d90743a Compare March 25, 2025 20:16
@smorimoto
Copy link
Author

I bumped the packages from cloudflare/workers-sdk in this PR to sync with the vite plugin release, but you can revert it if you like. It was done to reduce transitive dependency diffs.

@smorimoto smorimoto force-pushed the remove-assets-from-wrangler-conf branch from d90743a to ed38459 Compare March 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant