Skip to content

refactor(create-react-router): use native Node.js instead of recursive-readdir #13735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

refactor(create-react-router): use native Node.js instead of recursive-readdir #13735

merged 1 commit into from
Jun 6, 2025

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 3, 2025 •
edited
Loading

I'm sure people from the wider @e18e ecosystem cleanup (like @43081j & @outslept) will be very happy to see these kind of changes as well

@MichaelDeBoey MichaelDeBoey added dependencies Pull requests that update a dependency file pkg:create-react-router labels Jun 3, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c580c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 4, 2025
Open
@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch from d61d3a0 to 6007529 Compare June 4, 2025 01:52
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 4, 2025
Open
43081j
43081j reviewed Jun 4, 2025
View reviewed changes
@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch from 6007529 to 5da38b7 Compare June 4, 2025 12:02
@MichaelDeBoey MichaelDeBoey requested a review from 43081j June 4, 2025 12:06
@43081j
Copy link

43081j commented Jun 4, 2025

(sorry for the re-approval, was trying to close off my old review comments but it didn't work 😅 )

the filter change did work in the end it seems 👍

@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch 4 times, most recently from 4321b12 to 290488b Compare June 5, 2025 23:00
@MichaelDeBoey MichaelDeBoey force-pushed the remove-recursive-readdir-usage branch from 290488b to c580c96 Compare June 6, 2025 00:08
@timdorr
Copy link
Member

timdorr commented Jun 6, 2025

Looks pretty similar to #13736 in scope. Thanks for getting this cleaned up!

@timdorr timdorr merged commit d0bf252 into remix-run:dev Jun 6, 2025
8 checks passed
@MichaelDeBoey MichaelDeBoey deleted the remove-recursive-readdir-usage branch June 6, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdorr timdorr timdorr approved these changes

@43081j 43081j 43081j approved these changes

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees
No one assigned
Labels
CLA Signed dependencies Pull requests that update a dependency file pkg:create-react-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @43081j @timdorr