Escape optimizeDeps.entries paths in ssr environment#14414
Open
jamesopstad wants to merge 2 commits intoremix-run:mainfrom
Open
Escape optimizeDeps.entries paths in ssr environment#14414jamesopstad wants to merge 2 commits intoremix-run:mainfrom
optimizeDeps.entries paths in ssr environment#14414jamesopstad wants to merge 2 commits intoremix-run:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3c80252 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamesopstad
force-pushed
the
fix-optimize-deps-entries
branch
from
8b908fe to
3c80252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@markdalgleish and I discussed #13570. That was then closed in favour of #13748, which didn't apply the path escaping to
optimizeDeps.entriesfor thessrenvironment. This PR fixes that.Note that there needs to be some follow-up work outside this PR to ensure that
ssrandrscenvironments support optimising server dependencies with the new RSC support.