Fog of war loading state on initial render#14658
Closed
Nirva-Software wants to merge 2 commits intoremix-run:devfrom
Closed
Fog of war loading state on initial render#14658Nirva-Software wants to merge 2 commits intoremix-run:devfrom
Nirva-Software wants to merge 2 commits intoremix-run:devfrom
Conversation
|
Contributor
|
Thank you for the PR, but this fix isn't quite right as before the router is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14556
Expected Behavior
Expected behavior is to have the 'Navigation state' set to 'loading' and the content displaying 'Loading...' during the first few seconds when the route is loaded.
Actual Behavior
The 'Navigation state' stays at 'idle' and the content displays 'Not found'. After a few seconds, the content changes to the actual content of the page.
Includes modifications of lazy-discovery-test to reproduce/check that the issue is fixed.