Add focus styles to the Remix Jam FAQ to improve accessibility #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the keyboard to navigate the FAQ toggles, no focus styles are shown except when the FAQ is expanded.
brookslybrand
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks so much for helping make this experience a bit better!
I went ahead and removed the outline, since we're now using custom styles for focus
I also switched to focus-visible so the styles only apply if tabbed (vs click and click off). Also added group to the summary to fix the opacity style for the icon
keyboard.yafw.balanced.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the keyboard to navigate the FAQ toggles, no focus styles are shown except when the FAQ is expanded.