getListing exclude deleted items

CHANGELOG.md

@@ -12,6 +12,7 @@ system. Old cached data will be converted to the new format automatically.
 
 * `getAll` and `getListing` now return an empty object instead of undefined when no items
   match the query
+* `getListing` no longer includes Content-Type information; use `getFile` for that now.
 * `disconnect` event removed in favor of `disconnected`
 * `remoteStorage.claimAccess` removed in favor of `remoteStorage.access.claim`
 * `BaseClient#use` and `BaseClient#release` removed in favor of `BaseClient#cache`

src/baseclient.js

@@ -14,9 +14,12 @@
    *
    * A BaseClient deals with three types of data: folders, objects and files.
    *
-   * <getListing> returns a list of all items within a folder, or undefined
-   * if a 404 is encountered. Items that end with a forward slash ("/") are
-   * child folders.
+   * <getListing> returns a mapping of all items within a folder. Items that
+   * end with a forward slash ("/") are child folders. For instance:
+   * {
+   *   'folder/': true,
+   *   'document.txt': true
+   * }
    *
    * <getObject> / <storeObject> operate on JSON objects. Each object has a type.
    *
@@ -199,9 +202,11 @@
      * Example:
      *   (start code)
      *   client.getListing('', false).then(function(listing) {
-     *     listing.forEach(function(item) {
-     *       console.log(item);
-     *     });
+     *     //listing is for instance:
+     *     {
+     *       'folder/': true,
+     *       'document.txt': true
+     *     };
      *   });
      *   (end code)
      */

src/cachinglayer.js

@@ -174,6 +174,13 @@
         this.getNodes([path]).then(function(objs) {
           var node = getLatest(objs[path]);
           if (node) {
+            if (isFolder(path)) {
+              for (var i in node.itemsMap) {
+                if (node.itemsMap[i] === false) {
+                  delete node.itemsMap[i];
+                }
+              }
+            }
             promise.fulfill(200, node.body || node.itemsMap, node.contentType);
           } else {
             promise.fulfill(404);

test/unit/inmemorycaching-suite.js

@@ -113,6 +113,33 @@ define(['requirejs'], function(requirejs) {
         }
       },
 
+      {
+        desc: "#get removes falsy items from local version itemsMap",
+        run: function(env, test) {
+          var requestQueued = false;
+          var oldTimestamp = (new Date().getTime()) - 1000;
+
+          env.rs.local._storage['/'] = {
+            path: '/',
+            common: {
+              itemsMap: { foo: true, bar: true },
+              timestamp: oldTimestamp,
+              revision: '123'
+            },
+            local: {
+              itemsMap: { foo: true, bar: false },
+              timestamp: oldTimestamp,
+              revision: '123'
+            }
+          };
+          env.rs.local.get('/', false).then(function(status, itemsMap) {
+            test.assertAnd(status, 200);
+            test.assertAnd(itemsMap, { foo: true });
+            test.done();
+          });
+        }
+      },
+
       {
         desc: "#get gets queued as a sync request if node is older than the maxAge",
         run: function(env, test) {