Fix user guide about models #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The example grammar was incorrect, at least for parsing. For ANTLR, character classes are invalid in parser rules, may only be used in lexer rules. Thus, grammar was rewritten to use lexer rules. - In the python examples, indentation was off by one for `quantify` and `charset` methods. Fixed. - The `quantify` methods in the examples used an old API: the number and names of arguments was incorrect, and the methods still acted as generators. So, the `cnt` argument was added, `min` and `max` were renamed to `start` and `stop`, and `return` was used instead of `yield`ing. - Since the `decimal` rule in the grammar got turned into an lexer rule, `Decimal` nodes don't have children anymore. Thus, `charset` methods in the examples have been updated to make decisions based on token length instead of children count. - It got revealed that `charset` methods don't get charsets as lists but as tuples. The documentation of `Model.charset` had to updated and example `charset` methods had to be adapted. - All methods in the `DispatchingModel` subclass example fell into infinite recursion. The use of `super()` in the subclass directed the call to the method defined in `DispatchingModel`, which in turn called back into the subclass (and so on), instead of calling to the method in `DefaultModel`, the parent class of `DispatchingModel` and the grandparent of the subclass. Fixed by using the two-argument version of `super(..., ...)`. Fixes: renatahodovan#272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quantifyandcharsetmethods. Fixed.quantifymethods in the examples used an old API: the number and names of arguments was incorrect, and the methods still acted as generators. So, thecntargument was added,minandmaxwere renamed tostartandstop, andreturnwas used instead ofyielding.decimalrule in the grammar got turned into an lexer rule,Decimalnodes don't have children anymore. Thus,charsetmethods in the examples have been updated to make decisions based on token length instead of children count.charsetmethods don't get charsets as lists but as tuples. The documentation ofModel.charsethad to updated and examplecharsetmethods had to be adapted.DispatchingModelsubclass example fell into infinite recursion. The use ofsuper()in the subclass directed the call to the method defined inDispatchingModel, which in turn called back into the subclass (and so on), instead of calling to the method inDefaultModel, the parent class ofDispatchingModeland the grandparent of the subclass. Fixed by using the two-argument version ofsuper(..., ...).Fixes: #272