Fix warnings and set warnings as error when testing #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoGarcia
force-pushed
the
fix_warnings
branch
4 times, most recently
from
0c75de8 to
174daba
Compare
renatoGarcia
force-pushed
the
fix_warnings
branch
9 times, most recently
from
0c6a075 to
71ab9e3
Compare
We either fix or silence all warning triggered by:
-Wall -Wextra -Wconversion -Wshadow -pedantic
in GCC and Clang, and:
/Wall
in MSVC.
renatoGarcia
force-pushed
the
fix_warnings
branch
2 times, most recently
from
e4470df to
f732d51
Compare
renatoGarcia
force-pushed
the
fix_warnings
branch
from
f732d51 to
1205f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.