Open
Conversation
mars-low
reviewed
Nov 28, 2023
| { | ||
| if(value && sequencer.IsHalted) | ||
| { | ||
| sequencer.SP = machine.SystemBus.ReadDoubleWord(SequencerMemoryBaseAddress); |
Contributor
There was a problem hiding this comment.
It may be necessary to explicitly initialize Vector Table Offset, because otherwise the communication breaks after pause/start. During resuming after pause, InitPCAndSP() is called in OnResume() and VectorTableOffset for sequencer should be manually initialized prior to this to not be overridden by the automatically deduced address of the first non null section.
Suggested change
| sequencer.SP = machine.SystemBus.ReadDoubleWord(SequencerMemoryBaseAddress); | |
| sequencer.VectorTableOffset = SequencerMemoryBaseAddress; | |
| sequencer.SP = machine.SystemBus.ReadDoubleWord(SequencerMemoryBaseAddress); |
Contributor
Author
There was a problem hiding this comment.
@mars-low thank you for the suggestion. I will give this a try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary support for xG24 Silicon Labs platform.