fix(web): improve error message for required fields#3209
Merged
Conversation
emosbaugh
previously requested changes
Nov 14, 2025
| // Helper function to get the general error message we show at the bottom of the page after a form submission | ||
| export function getGeneralErrorMsgForSubmission(error: ApiError) { | ||
| if (error.fieldErrors && error.fieldErrors.length > 0) { | ||
| return "Required items are missing" |
Member
There was a problem hiding this comment.
We also have regexp validation. Should we make this error more generic?
Contributor
Author
There was a problem hiding this comment.
Thanks for the callout, changed the msging via - d6ba1eb
JGAntunes
force-pushed
the
jgantunes/sc-130954/improve-error-message-when-required-fields
branch
from
25c1507 to
d6ba1eb
Compare
sgalsaleh
approved these changes
Dec 3, 2025
JGAntunes
deleted the
jgantunes/sc-130954/improve-error-message-when-required-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve msging for when form submission fails with required fields missing.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/130954/improve-error-message-when-required-fields-aren-t-filled-in-on-config-page
Does this PR require a test?
Yes, updated the unit tests.
Does this PR require a release note?
Does this PR require documentation?
NONE