Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP, backlog task) - Add post init action for Flannel Addon to check UDP connection accros nodes #4565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(WIP, backlog task) - Add post init action for Flannel Addon to check UDP connection accros nodes #4565

wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented May 30, 2023 •
edited
Loading

What this PR does / why we need it:

Currently, we do not verify the connection between pods and nodes after flannel get installed.
This PR adds a post init check for we validate the installation/configuration

Which issue(s) this PR fixes:

Fixes # [sc-69490]

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Adds new check to verify the Pod Connection with Flannel. For multi node installs it will check if the communication across nodes also works.

Does this PR require documentation?

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-b6e5b44-flannel-0.21.5-k8s-ctrd-2023-05-30T11:42:52Z

@camilamacedo86 camilamacedo86 added the type::feature An enhancement to an existing add on or feature label May 30, 2023
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-c172fee-flannel-0.21.5-k8s-ctrd-2023-05-31T07:26:02Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-cd8da57-flannel-0.21.5-k8s-ctrd-2023-05-31T20:45:17Z

@camilamacedo86 camilamacedo86 changed the title Flannel check upd (Do not merge, WIP)Flannel check upd Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-2ba11ff-flannel-0.21.5-k8s-ctrd-2023-06-01T05:36:14Z

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-e1be44d-flannel-0.21.5-k8s-ctrd-2023-06-02T22:59:22Z

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-203a7b0-flannel-0.21.5-k8s-ctrd-2023-06-03T06:51:50Z

@camilamacedo86 camilamacedo86 changed the title (Do not merge, WIP)Flannel check upd Add post init action for Flannel Addon to check UDP connection accros nodes Jun 3, 2023
@camilamacedo86 camilamacedo86 marked this pull request as ready for review June 3, 2023 11:02
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner June 3, 2023 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-045bf87-flannel-0.21.5-k8s-ctrd-2023-06-03T11:02:08Z

@camilamacedo86 camilamacedo86 reopened this Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-7e775a8-flannel-0.21.5-k8s-ctrd-2023-06-03T11:04:19Z

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-9bc9729-flannel-0.21.5-k8s-ctrd-2023-06-03T11:09:22Z

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-afb5ddb-flannel-0.21.5-k8s-ctrd-2023-06-03T11:13:41Z

@camilamacedo86 camilamacedo86 changed the title Add post init action for Flannel Addon to check UDP connection accros nodes (WIP, backlog task) - Add post init action for Flannel Addon to check UDP connection accros nodes Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-ce86f0f-flannel-0.21.5-k8s-ctrd-2023-06-06T13:27:28Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4565-d893e21-flannel-0.21.5-k8s-ctrd-2023-06-20T09:07:49Z

rrpolanco
rrpolanco reviewed Jun 20, 2023
View reviewed changes
addons/flannel/template/base/install.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at flannel_check_nodes_connectivity and the netutil nodes-connectivity kURL CLI command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrpolanco rrpolanco rrpolanco left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type::feature An enhancement to an existing add on or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @rrpolanco