Add total cost on cluster create dry run #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
previously approved these changes
Jul 18, 2024
emosbaugh
requested changes
Jul 18, 2024
pkg/types/cluster.go
Outdated
| FlatFee int64 `json:"flat_fee"` | ||
| TotalCredits int64 `json:"total_credits"` | ||
|
|
||
| EstimatedCost int64 `json:"_"` |
There was a problem hiding this comment.
is this supposed to be a hyphen?
emosbaugh
requested changes
Jul 20, 2024
pkg/types/cluster.go
Outdated
| FlatFee int64 `json:"flat_fee"` | ||
| TotalCredits int64 `json:"total_credits"` | ||
|
|
||
| EstimatedCost int64 |
There was a problem hiding this comment.
Not sure what you are going for here. Shouldn't this have some sort of json tag? If you were to list clusters --output json this probable doesn't look right the way it is.
There was a problem hiding this comment.
You're right. I was thinking as EstimatedCost is calculated (part of dry-run, or calculated for cluster list), it didn't have to go into json, but totally forgot about --output=json
emosbaugh
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.