-
Notifications
You must be signed in to change notification settings - Fork 26
add replicated vm ssh-endpoint
command to print the ssh endpoint of a vm
#531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should bring back the interactivity that was removed in #532, if I don't provide a VM ID I should still be able to select one from the list. I liked that addition. The difference being we'd just output the ssh URI from the selection rather than start a new SSH session.
The problem with having interactivity in something we expect to run in subshells is that it doesn't always work the way we expect, things run inside bash's |
Maybe a happy middle ground would be to print a I dunno, I see a benefit to keeping I'm going to approve this and then we can discuss the potential of keeping |
This enables users to use tools other than
ssh
or to construct more complicates commands with the endpoint.i.e: