update deps and restrict published file list #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nightwing
commented
Mar 18, 2025
•
nightwing
commented
- removed .npmignore in favor of explicit whitelist since we only publish dist folder
- removed yarn.lock since it was not included in published package and is generating annoying pull requests from dependabot
- updated dependencies to the latests versions
nightwing
force-pushed
the
fix-deps
branch
2 times, most recently
from
ff9725d to
a77001a
Compare
masad-frost
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Lock files are still good for consistent builds and avoiding supply chain attacks
masad-frost
requested changes
Mar 18, 2025
|
Ok, i have restored the lockfile, and updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.