Skip to content

make propagated build data optional #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make propagated build data optional #42

wants to merge 1 commit into from

Conversation

vlinkz
Copy link
Contributor

@vlinkz vlinkz commented Feb 18, 2025

Why

Including propagated build inputs increases build time and index size, so lets make it optional (disabled by default).

What changed

Added --build_propagated_inputs flag to rippkgs-index to optionally enable including propagated{,Native}BuildInputs in index.

Test plan

@vlinkz vlinkz requested a review from a team as a code owner February 18, 2025 20:39
@vlinkz vlinkz requested review from blast-hardcheese and removed request for a team February 18, 2025 20:39
blast-hardcheese
blast-hardcheese approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you also save these actions from bitrot?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blast-hardcheese blast-hardcheese blast-hardcheese approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlinkz @blast-hardcheese