[python] don't attempt systemdep install if no deps #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlinkz
requested review from
jackyzha0 and
ryantm
and removed request for
a team
ryantm
approved these changes
Jun 13, 2025
|
Hm this is not actually fixing it in the right place. I'll fix in a min, but we should check if no new packages are added, not no packages at all. |
vlinkz
force-pushed
the
vlinkz/dontaddnixifnodeps
branch
from
2e5a082 to
9eb8104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If no system dependencies are found, don't to toml-editor nop.
What changed
Check if no system dependencies need to be installed for python packages.
Test plan