Skip to content

remove bash from python system deps map #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

remove bash from python system deps map #358

merged 2 commits into from
Jun 17, 2025

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Jun 17, 2025

Why

  • adding bash via nix breaks the Replit shell, and we already have bash available, so this doesn't make sense to have.

What changed

  • Remove bash and bashInteractive

Test plan

  • CI passes
  • Try to add "bash_kernel" package via Python and confirm that bash does not get installed.

Why
===
* adding bash via nix breaks the Replit shell, and we already have
bash available, so this doesn't make sense to have.

What changed
===
* Remove bash and bashInteractive

Test plan
===
* CI passes
* Try to add "bash_kernel" package via Python and confirm that bash does not
get installed.
@ryantm ryantm requested a review from a team as a code owner June 17, 2025 20:28
@ryantm ryantm requested review from daweifeng-replit and removed request for a team June 17, 2025 20:28
@ryantm ryantm enabled auto-merge (squash) June 17, 2025 20:43
@ryantm ryantm merged commit ec3eda5 into main Jun 17, 2025
5 checks passed
@ryantm ryantm deleted the rtm-06-17-remove-bash branch June 17, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants