Skip to content

EPMRPP-103879 || Make sorting case insensitive #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

allaprischepa
Copy link
Contributor

@allaprischepa allaprischepa commented Jun 23, 2025

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?
  • Have you added the link to the PR in the Jira ticket comments?

Visuals

Sorting works as expected:
Screenshot 2025-06-23 095106
Screenshot 2025-06-23 095228

Summary by CodeRabbit

  • Chores

    • Updated a dependency to the latest version.
  • Refactor

    • Adjusted how sorting direction is handled in table components to pass the value directly without converting to lowercase. This change affects user, organization, and project tables.

Copy link

coderabbitai bot commented Jun 23, 2025

Walkthrough

The updates remove the conversion of the sortingDirection prop to lowercase before passing it to Table components in several files. Additionally, the dependency @reportportal/ui-kit in package.json is updated to a new alpha version.

Changes

File(s) Change Summary
app/package.json Updated @reportportal/ui-kit dependency version.
app/src/pages/common/users/membersListTable/membersListTable.jsx Removed .toLowerCase() from sortingDirection prop for Table.
app/src/pages/instance/organizationsPage/organizationsPanelView/organizationsTable/organizationsTable.jsx Removed .toLowerCase() from sortingDirection prop for Table.
app/src/pages/organization/organizationProjectsPage/projectsListTable/projectsListTable.jsx Removed .toLowerCase() from sortingDirection prop for Table.

Suggested reviewers

  • AmsterGet
  • BlazarQSO

Poem

A hop, a skip, a version bump,
No more lowercasing in the sorting lump.
Tables now take what they're given,
As new UI-Kit code is driven.
With every change, the garden grows—
Onward the project, as the spring breeze blows! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 020b0df and 8d05c62.

⛔ Files ignored due to path filters (1)
  • app/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • app/package.json (1 hunks)
  • app/src/pages/common/users/membersListTable/membersListTable.jsx (1 hunks)
  • app/src/pages/instance/organizationsPage/organizationsPanelView/organizationsTable/organizationsTable.jsx (1 hunks)
  • app/src/pages/organization/organizationProjectsPage/projectsListTable/projectsListTable.jsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/src/pages/organization/organizationProjectsPage/projectsListTable/projectsListTable.jsx (1)
app/src/components/widgets/multiLevelWidgets/testCaseSearchTable/testCaseSearch.jsx (1)
  • sortingDirection (59-59)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Call feature Docker build / Build and export to AWS ECR
  • GitHub Check: build (20)
  • GitHub Check: build (20)
🔇 Additional comments (4)
app/package.json (1)

30-30: Verify the UI kit version update aligns with the sorting changes.

The UI kit dependency has been updated to support case-insensitive sorting internally. Ensure that version ^0.0.1-alpha.66 includes the expected sorting functionality that eliminates the need for .toLowerCase() transformation in application code.

What changes were made in @reportportal/ui-kit version 0.0.1-alpha.66 related to table sorting functionality?
app/src/pages/organization/organizationProjectsPage/projectsListTable/projectsListTable.jsx (1)

143-143: LGTM! Improved separation of concerns.

The removal of .toLowerCase() transformation moves case handling responsibility to the Table component itself, which is a better architectural approach. This change aligns with the PR objective to implement case-insensitive sorting.

app/src/pages/instance/organizationsPage/organizationsPanelView/organizationsTable/organizationsTable.jsx (1)

187-187: LGTM! Consistent implementation across table components.

This change maintains consistency with other table components by removing the .toLowerCase() transformation and delegating case handling to the Table component.

app/src/pages/common/users/membersListTable/membersListTable.jsx (1)

60-60: LGTM! Completes the consistent refactoring.

This change completes the consistent implementation across all table components, ensuring that case handling is uniformly delegated to the Table component. The refactoring improves code maintainability and reduces duplication.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch feature/EPMRPP-103879-make-sorting-case-insentive

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (020b0df) to head (8d05c62).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4421   +/-   ##
========================================
  Coverage    66.53%   66.53%           
========================================
  Files           85       85           
  Lines          983      983           
  Branches       140      140           
========================================
  Hits           654      654           
  Misses         298      298           
  Partials        31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allaprischepa allaprischepa merged commit 0adca97 into develop Jun 23, 2025
10 checks passed
@allaprischepa allaprischepa deleted the feature/EPMRPP-103879-make-sorting-case-insentive branch June 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants