-
Notifications
You must be signed in to change notification settings - Fork 109
EPMRPP-103964 || Add sorting by name for All users page #4422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-103964 || Add sorting by name for All users page #4422
Conversation
WalkthroughThe changes update the user property naming convention from camelCase ( Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AllUsersListTableComponent
participant Constants
User->>AllUsersListTableComponent: Loads user list page
AllUsersListTableComponent->>Constants: Fetches DEFAULT_SORT_COLUMN, SORTING_KEY
AllUsersListTableComponent->>AllUsersListTableComponent: Maps user data using 'full_name'
AllUsersListTableComponent->>AllUsersListTableComponent: Configures sorting with 'full_name'
AllUsersListTableComponent-->>User: Displays sorted user list by full name
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4422 +/- ##
========================================
Coverage 66.53% 66.53%
========================================
Files 85 85
Lines 983 983
Branches 139 139
========================================
Hits 654 654
Misses 298 298
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48b0214
to
6118a71
Compare
Force pushed to resolve out-of-date issue |
|
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?dev
npm script)manage:translations
script?Visuals
Summary by CodeRabbit