RQLY-1153 upgrade dependencies #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed Linux action still fails when the |
after electron v20 all render processes are sandboxed by default https://www.electronjs.org/blog/electron-20-0\#default-changed-renderers-without-nodeintegration-true-are-sandboxed-by-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all audit bugs
@electron/*instead ofelectron-*wherever deprecatedUpdates release pipeline node version to 16.15.0
Known issue introduced - signing and afterSign not triggered
This is because earlier, electron-builder's
afterSignhook was faulty and would also trigger when wrongly configured (which I guess is the case in our application). Reference - electron-userland/electron-builder#7311The build is still notarized (requires an extra
APPLE_APP_SPECIFIC_PASSWORDenvironment variable) but not signed.As a result of this erb's
notarize.jsis not executed.