This repository was archived by the owner on Apr 14, 2025. It is now read-only.
Fix unsound problem in Row::row_unchecked
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your folk of arrow and best wishes first.
We have found a simple unsound problem in
::compute::sort::row::Rows.The function
Rows::row_uncheckedis wrongly marked as safe, which would confuse the boundary between safe and unsafe Rust.Since the repository of arrow2 have been archived, we cannot create any issue report. So we directly open this PR to mark the function
row_uncheckedas 'unsafe' and add adebug_assert!macro for safety consideration.