Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReScript 11 scaffolding #726

Merged
merged 34 commits into from
Dec 5, 2023
Merged

ReScript 11 scaffolding #726

merged 34 commits into from
Dec 5, 2023

Conversation

fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Oct 16, 2023

Supersedes #722 which used the wrong base repository.
PRs for rescript-11 docs can now go into the rescript-11 branch which is tracked by this PR.

* Adapt some pages to ReScript 11 including records and variants

* Some better wordings

* Variants: Add some TODOs
@zth
Copy link
Collaborator

zth commented Oct 25, 2023

@fhammerschmidt I rebased on master because of the last rather large PR that was merged.

* untagged variants

* variant type spread docs

* variant coercion

* catch-all case

* rearrange
* Adapt some pages to ReScript 11 including records and variants

* Some better wordings

* Adapt example tests to Rescript11 + uncurried + RescriptCore

* Change more examples from Belt to RescriptCore

* Fix uncurried error

* Consistent quotes

* Fix remaining test

* Mention RescriptCore in try section

* Add dummy file
Remove "Migrate from BuckleScript/Reason" guide
@@ -0,0 +1 @@
Console.log("I am a dummy file")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this about?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed a dummy ReScript project to get a compiled version of ReScript Core in the test-examples.mjs script.
When you delete the dummy file and try to execute the script without node_modules installed, it will fail

@fhammerschmidt
Copy link
Member Author

Just added this banner to the latest docs layouts:
image

@fhammerschmidt fhammerschmidt merged commit 0c30fe8 into master Dec 5, 2023
2 checks passed
@fhammerschmidt fhammerschmidt deleted the rescript-11 branch December 5, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants