Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new templates urls #760

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Dec 10, 2023

Remove templates section from Landing page.

Add new template URLs to repo https://github.com/rescript-lang/create-rescript-app

image

@ryyppy
Copy link
Member

ryyppy commented Dec 18, 2023

I'd still want to highlight on the landing page what's available within create-rescript-app. How does one know what ReScript supports out of the box?

@aspeddro
Copy link
Collaborator Author

@fhammerschmidt create-rescript-app support arguments? We can add code block like create-rescript-app --with-nextjs

@fhammerschmidt
Copy link
Member

Yes. For now it only supports the project name as the first parameter
e.g.
npm create rescript-app@next my-project
but it can be easily extended to support more

@aspeddro
Copy link
Collaborator Author

Ok. We can place a block of code inside the card. What you think @ryyppy?

npx create-rescript-app --with nextjs

image

@ryyppy
Copy link
Member

ryyppy commented Dec 18, 2023

I think this card should just link to the getting started page with the relevant create-rescript-app snippet... ideally later on to an actual nextjs tutorial page that uses that npx command.

I would probably not put that install link right on the card or on the front page

@aspeddro aspeddro changed the title Remove templates section Add new templates urls Jan 7, 2024
@aspeddro aspeddro marked this pull request as draft January 7, 2024 01:02
@aspeddro aspeddro marked this pull request as ready for review January 10, 2024 20:44
@aspeddro
Copy link
Collaborator Author

This can be merged when create-rescript-app 1.6.0 is released.

cc @cknitt @fhammerschmidt

@fhammerschmidt
Copy link
Member

Will merge this now, as the release is today.

@fhammerschmidt fhammerschmidt merged commit be7cd25 into rescript-lang:master Jan 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants